Skip to content

fix: profile picture sync#949

Merged
coodos merged 1 commit intomainfrom
fix/image-sync
Apr 8, 2026
Merged

fix: profile picture sync#949
coodos merged 1 commit intomainfrom
fix/image-sync

Conversation

@coodos
Copy link
Copy Markdown
Contributor

@coodos coodos commented Apr 8, 2026 •
edited by coderabbitai bot
Loading

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of profile avatar and banner data during synchronization to ensure empty or missing images are properly managed, preventing potential sync inconsistencies.

@coodos coodos marked this pull request as ready for review April 8, 2026 11:01
@coodos coodos merged commit 9a85592 into main Apr 8, 2026
3 of 4 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 82c39e3b-942b-46e0-8b65-fb47bfb0b34b

📥 Commits

Reviewing files that changed from the base of the PR and between 2dbe070 and 0307891.

📒 Files selected for processing (1)
  • platforms/profile-editor/api/src/services/EVaultSyncService.ts
📝 Walkthrough

Walkthrough

Updated EVaultSyncService methods syncUser and syncUserToSearchDb to build payload objects that omit avatar and banner unless those profile values are truthy, then pass the constructed payload to upsertFromWebhook; error handling and control flow preserved.

Changes

Cohort / File(s) Summary
EVaultSyncService refactoring
platforms/profile-editor/api/src/services/EVaultSyncService.ts		 Replaced inline payloads with a data object in syncUser and syncUserToSearchDb; avatar and banner are conditionally added only when truthy. Calls to upsertFromWebhook(data) and existing .catch/logging remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • xPathin
  • sosweetham

Poem

🐰 I nudge the code with careful paws,

Only truthy treasures pass my laws,
No empty banners crowd the view,
Clean payloads hop—simple and true. 🥕

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/image-sync

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coodos coodos deleted the fix/image-sync branch April 8, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@coodos